fix(Core/Combat): Update to new ThreatManager API#77
Open
blinkysc wants to merge 1 commit intoazerothcore:masterfrom
Open
fix(Core/Combat): Update to new ThreatManager API#77blinkysc wants to merge 1 commit intoazerothcore:masterfrom
blinkysc wants to merge 1 commit intoazerothcore:masterfrom
Conversation
Replace removed GetThreatList() with GetSortedThreatList() and getTarget() with GetVictim() to match AzerothCore's ported heap-based threat system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GetThreatList()withGetSortedThreatList()in mythic mode distance target logicgetTarget()withGetVictim()onThreatReferenceContext
Required for compatibility with azerothcore/azerothcore-wotlk#24715 which ports TrinityCore's heap-based threat system.
Test plan
TARGET_PLAYER_DISTANCEspell casting works correctly